[FELIX-2691] Apache Felix HTTP service HttpServiceImpl.isNameValid does not match OSGi R4.2 spec?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: http-2.0.4
• Fix Version/s: http-2.2.0
• Component/s: HTTP Service
• Environment: Not relevant
• Assignee: Felix Meschberger
• Reporter: Misha Koshelev
• Created: 09/Nov/10 18:59
• Updated: 08/Feb/11 09:46
• Resolved: 08/Jan/11 00:27

Description

Filing bug per:
http://www.mail-archive.com/[e-mail]/msg19853.html

The R4.2 enterprise spec from
http://www.osgi.org/Download/File?url=/download/r4v42/r4.enterprise.pdf
on page 48 clearly states:

The name parameter must also not end with slash ('/') with the
exception that a name of the form "/" is used to denote the root of
the bundle.

The relevant code, in trunk, is, from
http://svn.apache.org/repos/asf/felix/trunk/http/base/src/main/java/org/apache/felix/http/base/internal/service/HttpServiceImpl.java

public void registerResources(String alias, String name, HttpContext context)
throws NamespaceException
{
if (!isNameValid(name))

{ throw new IllegalArgumentException( "Malformed resource name [" + name + "]"); }

...

and

private boolean isNameValid(String name)
{
if (name == null)

{ return false; }

if (name.endsWith( "/" )) { return false; }

return true;
}