[FELIX-2318] Possible NPE for jars with null Manifest

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: fileinstall-3.1.0
• Component/s: File Install
• Assignee: Guillaume Nodet
• Reporter: Sanjeeb Kumar Sahoo
• Created: 03/May/10 14:23
• Updated: 16/May/17 08:41
• Resolved: 26/Oct/10 07:02

Description

JarFile.getManifest() can return null, so caller must check return value for null-ness to avoid NPE. I see two such occurrences in fileinstall:

DirectoryWatcher.java:
private Bundle installOrUpdateBundle(
String bundleLocation, BufferedInputStream is, long checksum)
throws IOException, BundleException
{
is.mark(256 * 1024);
JarInputStream jar = new JarInputStream(is);
Manifest m = jar.getManifest();
String sn = m.getMainAttributes().getValue(Constants.BUNDLE_SYMBOLICNAME);
...

BundleTransformer.java:
Manifest m = jar.getManifest();
if (m.getMainAttributes().getValue(new Attributes.Name("Bundle-SymbolicName")) != null)
...