Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-2301

Fix some site.css glitches

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • Documentation
    • None

    Description

      The current CSS of the Apache Felix site [1] IMHO has a few issues:

      • Tables have no broders, thus they are hard to identify as tables and cells are hard to distinguish
      • Tables need a top and bottom margin to set them off from the previous and next elements
      • Table row are align "middle", they should probably be aligned "top" for better readability
      • XML code has an margin on the <pre> element (should be removed like for Java code)
      • Headers h1, h2, and h3 should probably be rendered in bold weight (rather than normal weight)
      • Headers need a top margin, otherwise the "glue" to the previous element

      Here is a diff for the proposed changes:

      $ diff -b site.css site.css.new
      4c4
      < h1, h2, h3, h4, h5, h6

      { font-weight: normal; color: #000000; line-height: 100%; margin-top: 0px}


      > h1, h2, h3, h4, h5, h6

      { font-weight: bold; color: #000000; line-height: 100% }

      8,10c8,10
      < h4

      { font-size: 140% }

      < h5

      { font-size: 130% }

      < h6

      { font-size: 120% }


      > h4

      { font-size: 140%; font-weight: normal }

      > h5

      { font-size: 130%; font-weight: normal }

      > h6

      { font-size: 120%; font-weight: normal }

      25a26,29
      > .code-xml

      { margin: 0em }

      >
      > table.confluenceTable

      { border-collapse: collapse; margin: 10px 0 10px 0 }

      > td.confluenceTd

      { border:1px solid #CCCCCC; padding:5px; vertical-align:top; }

      WDYT ?

      [1] http://felix.apache.org/site/media.data/site.css

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            fmeschbe Felix Meschberger
            fmeschbe Felix Meschberger
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment