Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-2206

Localization causes a problem in Configuration Printers

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: webconsole-3.0.0
    • Component/s: Web Console
    • Labels:
      None

      Description

      When Configuration Status is opened, the Bundles and Services tabs are rendered respectively as 'bundles.pluginTitle' and 'services.pluginTitle'.

      Unfortunately, the ConfigurationRender cannot access the ResourceBundleManager which is required to translate the titles.

      So there are few possibilities:
      1. A dirty hack, when OsgiManager creates the ConfigurationRender calls a method, to set the resourceBundleManager.
      2. Make resource bundle manager accessible to all plugins as a request parameter. This will also require to make the ResourceBundleManager class public... or define the following interface in the public API:
      interface ResourceBundleManager {
      public ResourceBundle getResourceBundle( final Bundle provider, final Locale locale )
      }

      3. Refactor the Bundles & Services plugins, and change the title to respectively %Bundles and %Services. This is another dirty hack but the titles will be shown correctly.
      4. Refactor the Bundles & Services plugins and extract the configuration printer code in a separate class. In this case no localization will be supported for these printers - just like other ones. I want to remind again, that we choose that no localization is required for Configuration Status as the provided information is more for diagnostics and is better to remain not-localized.

      So what do you think. Which variant is better? I personally vote for 4. We can make some method static and package private, so they can be reused by both - plugins & printers can reduce the duplicate code to minimum.

        Attachments

        1. FELIX-2206-fmeschbe.patch
          11 kB
          Felix Meschberger
        2. services_config_printer.patch
          22 kB
          Valentin Valchev

          Activity

            People

            • Assignee:
              fmeschbe Felix Meschberger
              Reporter:
              v_valchev Valentin Valchev
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: