[FELIX-2195] Using URLDecoder.decode on locations is wrong

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: framework-2.0.4
• Fix Version/s: framework-2.0.5
• Component/s: Framework
• Assignee: Karl Pauls
• Reporter: David Jencks
• Created: 12/Mar/10 00:55
• Updated: 01/Apr/10 13:02
• Resolved: 22/Mar/10 21:07

Description

URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding the path component of a url. Using it for this produces wrong results. In partucular, mac os x likes to make temporary files with strings like "+++++++" in the path. When run through URLDecoder these turn into spaces which means felix can't find the file you just gave it a valid file system location for. Since equinox does this correctly we can't use felix in geronimo until this is fixed.

IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that lack URI and its correct decoding behavior. Fortunately apache harmony implements URI so the attached patch borrows the implementation from harmony to provide correct behavior on antique vms.