[FELIX-1831] Reinstalling of deployment package fails

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Cannot Reproduce
• Component/s: Deployment Admin
• Environment: Windows Vista x64, Apache Felix
• Assignee: Unassigned
• Reporter: Pavel Kodl
• Created: 30/Oct/09 07:22
• Updated: 24/Apr/13 14:45
• Resolved: 24/Apr/13 14:45

Description

In DeploymentAdminImpl class should be from line 240 something like this:

} else

{ // causes unlock deployment package manifest file m_packages.remove(source.getName()); System.gc(); // have to be here File targetPackage = m_context.getDataFile(PACKAGE_DIR + File.separator + source.getName()); targetPackage.mkdirs(); ExplodingOutputtingInputStream.replace(targetPackage, tempPackage); }

instead of:

} else

{ File targetPackage = m_context.getDataFile(PACKAGE_DIR + File.separator + source.getName()); targetPackage.mkdirs(); ExplodingOutputtingInputStream.replace(targetPackage, tempPackage); }

without this correction it throws:
org.osgi.service.deploymentadmin.DeploymentException: Could not create installed deployment package from disk
at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:252)
at org.apache.felix.webconsole.internal.deppack.DepPackServlet.doPost(DepPackServlet.java:94)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:296)
at org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:92)
at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:78)
at org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:42)
at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:49)
at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:33)
at org.apache.felix.http.base.internal.dispatch.FilterPipeline.dispatch(FilterPipeline.java:48)
at org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:39)
at org.apache.felix.http.base.internal.DispatcherServlet.service(DispatcherServlet.java:55)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:390)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:536)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:930)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:747)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:405)
at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
Caused by: java.io.FileNotFoundException: .\felix-cache\bundle23\data\packages\test4\index.txt
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.<init>(FileInputStream.java:106)
at java.io.FileReader.<init>(FileReader.java:55)
at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.readIndex(ExplodingOutputtingInputStream.java:212)
at org.apache.felix.deploymentadmin.FileDeploymentPackage.<init>(FileDeploymentPackage.java:52)
at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:247)
... 26 more