[FELIX-1422] Resolver does not always discard partial results when a cyclically dependency fails

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: framework-1.8.1
• Fix Version/s: framework-2.0.0
• Component/s: Framework, Specification compliance
• Assignee: Richard S. Hall
• Reporter: Richard S. Hall
• Created: 29/Jul/09 15:12
• Updated: 06/Oct/09 11:21
• Resolved: 28/Aug/09 15:42

Description

When resolving dependencies among bundles, if a cycle is detected the resolver algorithm assumes the resolve is successful. So, assuming we want to resolve A and A wants to import from B and B wants to import from A, we end up building up a data structure where A has B as a potential candidate and B has A. If A is unable to resolve, then the whole thing fails and everything is fine. However, if the resolve starts with C and C has an optional import from A, then when A fails to resolve it is ignored since it was optional for C. This means the partial resolve results for A will be discarded, but unfortunately the partial resolve results for B are not. This means if C also has a dependency on B, the partial resolve results will be used as if they were correct, even though they include A as a candidate, which could not be resolved. The end result is an NPE when creating wires, since it tries to create a wire to an unresolved bundle.

We need to remove assumptions we made about cycles if they ultimately fail to resolve.

Issue Links

• relates to: FELIX-1710 Resolver still does not discard all partial results when a cyclical dependency fails