Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-1013 Improve console extensibility
  3. FELIX-1015

Hardcoded HTML Header/Footer in AbstractWebConsolePlugin

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • webconsole-1.2.8
    • webconsole-2.0.0
    • Web Console
    • None

    Description

      Instead of

      private static final String HEADER = "<?xml version=\"1.0\" encoding=\"UTF-8\" ?>"
      + "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"xhtml1-transitional.dtd\">"
      + "<html xmlns=\"http://www.w3.org/1999/xhtml\">"
      + "<head>"
      + "<meta http-equiv=\"Content-Type\" content=\"text/html; utf-8\">"
      + "<link rel=\"icon\" href=\"

      {6}/res/imgs/favicon.ico\">"
      + "<title>{0} - {2}</title>"
      + "<script src=\"{5}/res/ui/jquery-1.3.2.min.js\" language=\"JavaScript\"></script>"
      + "<script src=\"{5}/res/ui/jquery.tablesorter-2.0.3.min.js\" language=\"JavaScript\"></script>"
      + "<script src=\"{5}/res/ui/admin.js\" language=\"JavaScript\"></script>"
      + "<script src=\"{5}/res/ui/ui.js\" language=\"JavaScript\"></script>"
      + "<script language=\"JavaScript\">"
      + "appRoot = \"{5}\";"
      + "pluginRoot = appRoot + \"/{6}

      \";"
      + "</script>"
      + "<link href=\"

      {5}/res/ui/admin.css\" rel=\"stylesheet\" type=\"text/css\">"
      + "</head>"
      + "<body>"
      + "<div id=\"main\">"
      + "<div id=\"lead\">"
      + "<h1>"
      + "{0}<br>{2}"
      + "</h1>"
      + "<p>"
      + "<a target=\"_blank\" href=\"{3}\" title=\"{1}\"><img src=\"{5}

      /res/imgs/logo.png\" width=\"165\" height=\"63\" border=\"0\"></a>"
      + "</p>" + "</div>";

      we propose

      protected String getHeader()
      {
      String HEADER = "<?xml version=\"1.0\" encoding=\"UTF-8\" ?>"
      + "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"xhtml1-transitional.dtd\">"
      + "<html xmlns=\"http://www.w3.org/1999/xhtml\">"
      + "<head>"
      + "<meta http-equiv=\"Content-Type\" content=\"text/html; utf-8\">"
      + "<link rel=\"icon\" href=\"

      {6}/res/imgs/favicon.ico\">"
      + "<title>{0} - {2}</title>"
      + "<script src=\"{5}/res/ui/jquery-1.3.2.min.js\" language=\"JavaScript\"></script>"
      + "<script src=\"{5}/res/ui/jquery.tablesorter-2.0.3.min.js\" language=\"JavaScript\"></script>"
      + "<script src=\"{5}/res/ui/admin.js\" language=\"JavaScript\"></script>"
      + "<script src=\"{5}/res/ui/ui.js\" language=\"JavaScript\"></script>"
      + "<script language=\"JavaScript\">"
      + "appRoot = \"{5}\";"
      + "pluginRoot = appRoot + \"/{6}

      \";"
      + "</script>"
      + "<link href=\"

      {5}/res/ui/admin.css\" rel=\"stylesheet\" type=\"text/css\">"
      + "</head>"
      + "<body>"
      + "<div id=\"main\">"
      + "<div id=\"lead\">"
      + "<h1>"
      + "{0}<br>{2}"
      + "</h1>"
      + "<p>"
      + "<a target=\"_blank\" href=\"{3}\" title=\"{1}\"><img src=\"{5}

      /res/imgs/logo.png\" width=\"165\" height=\"63\" border=\"0\"></a>"
      + "</p>" + "</div>";

      return HEADER;
      }

      -------------

      protected PrintWriter startResponse( HttpServletRequest request, HttpServletResponse response ) throws IOException

      { ... String header = MessageFormat.format( getHeader(), new Object[] }

      protected void endResponse( HttpServletRequest request, PrintWriter pw )

      { pw.println( "</body>" ); pw.println( "</html>" ); }

      Attachments

        1. branding.patch
          14 kB
          Marcin Wilkos
        2. branding2.patch
          13 kB
          Marcin Wilkos
        3. FELIX-1015-fmeschbe.patch
          18 kB
          Felix Meschberger

        Activity

          People

            fmeschbe Felix Meschberger
            tdiesler Thomas Diesler
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: