[FEDIZ-226] authnRequestBuilder cofiguration property for samlProtocolType ignored

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.4
• Fix Version/s: 1.4.5
• Component/s: Plugin
• Assignee: Colm O hEigeartaigh
• Reporter: ToBo
• Created: 25/Aug/18 19:21
• Updated: 09/Oct/18 11:56
• Resolved: 27/Aug/18 10:40

Description

authnRequestBuilder cofiguration property for samlProtocolType is ignored due to the bug in org.apache.cxf.fediz.core.config.SAMLProtocol line 84. It states following:
samlpRequestBuilder = new DefaultSAMLPRequestBuilder();

it means, that DefaultSAMLPRequestBuilder is created even if configuration defines custom authnRequestBuilder.
it should be something like this:
if (null == samlpRequestBuilder)
samlpRequestBuilder = new DefaultSAMLPRequestBuilder();