[FEDIZ-124] Fediz-plugin for Tomcat 8

• Type: Question
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.2
• Fix Version/s: 1.3.0
• Component/s: Plugin
• Labels: patch

Environment

Windows tomcat version

• Assignee: Colm O hEigeartaigh
• Reporter: ronald
• Created: 15/Jul/15 15:20
• Updated: 31/Mar/16 10:59
• Resolved: 04/Sep/15 11:13

Description

we currently using Fediz-plugin version 1.0.2 within Tomcat7. Now we have to upgrade Tomcat to version 8.
Fediz-plugin is build for Tomcat 6 & 7. Not for Tomcat 8.0.23 .

With which enhancments is this plugin do we have to make within the distribution?
the supplier of the application that uses the Fediz-plugin had made a diff and had the following differences:
////////////////////////
C:\projects\fediz-1.2.0\plugins>diff tomcat7\src\main\java\org\apache\cxf\fediz\tomcat\FederationAuthenticator.java tomcat8\src\main\java\org\apache\cxf\fediz\tomcat\FederationAuthenticator.java
— tomcat7\src\main\java\org\apache\cxf\fediz\tomcat\FederationAuthenticator.java Wed Jul 15 10:18:57 2015
+++ tomcat8\src\main\java\org\apache\cxf\fediz\tomcat\FederationAuthenticator.java Mon Jul 13 22:52:39 2015
@@ -40,7 +40,6 @@
import org.apache.catalina.authenticator.SavedRequest;
import org.apache.catalina.connector.Request;
import org.apache.catalina.connector.Response;
-import org.apache.catalina.deploy.LoginConfig;
import org.apache.cxf.fediz.core.FederationConstants;
import org.apache.cxf.fediz.core.FedizPrincipal;
import org.apache.cxf.fediz.core.config.FedizConfigurator;
@@ -85,14 +84,6 @@
LOG.debug("WsFedAuthenticator()");
}

• /**
• * Return descriptive information about this Valve implementation.
• */
• @Override
• public String getInfo() { - return INFO; - }

  -
  public String getConfigFile()

  { return configFile; }

  @@ -192,8 +183,7 @@
  }

@Override

• public boolean authenticate(Request request, HttpServletResponse response,
• LoginConfig config) throws IOException {
  + public boolean authenticate(Request request, HttpServletResponse response) throws IOException {

LOG.debug("authenticate invoked");
//////////////////////////////
are these the only differences or do we miss something?