[FC-99] fortress-core npe checking list

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 1.0.0-RC40
• Fix Version/s: 1.0.0-RC42
• Assignee: Unassigned
• Reporter: Shawn McKinney
• Created: 01/May/15 05:02
• Updated: 13/Jul/16 14:22
• Resolved: 13/Jul/16 14:22

Description

Corner case in fortress-web search on user page causes npe in core:

Caused by: java.lang.NullPointerException
at org.apache.directory.fortress.web.SerializableList.size(SerializableList.java:45)
at org.apache.directory.fortress.core.util.attr.VUtil.isNotNullOrEmpty(VUtil.java:539)
at org.apache.directory.fortress.web.panel.UserListPanel$4.onSubmit(UserListPanel.java:281)
at org.apache.wicket.ajax.markup.html.form.AjaxButton$1.onSubmit(AjaxButton.java:108)
at org.apache.wicket.ajax.form.AjaxFormSubmitBehavior$1.onSubmit(AjaxFormSubmitBehavior.java:182)
at org.apache.wicket.markup.html.form.Form.delegateSubmit(Form.java:1288)
at org.apache.wicket.markup.html.form.Form.process(Form.java:952)
at org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:784)
at org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:159)
at org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:124)
at org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:633)
... 52 more
WARN - 30 Apr 2015 23:53:42,339 - RequestCycleExtra - ********************************

The offending line of code below:

public static boolean isNotNullOrEmpty( Collection<?> list )

{ return ( list != null ) && ( list.size() > 0 ); <-- how is this npe? }