[FALCON-669] Missing optional workflow execution listeners configuration results in NPE

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6
• Fix Version/s: 0.6
• Assignee: Raghav Kumar Gautam
• Reporter: Raghav Kumar Gautam
• Created: 03/Sep/14 22:11
• Updated: 04/Sep/14 21:41
• Resolved: 04/Sep/14 21:41

Description

As of now workflow.execution.listners does not assume a default value.

        String listenerClassNames = StartupProperties.get().getProperty(
                "workflow.execution.listeners");

This means that if it is not configured - at the startup we will get NPE.

2014-09-03 14:48:59,583 ERROR - [main:] ~ Failed to initialize service org.apache.falcon.workflow.WorkflowJobEndNotificationService (ServiceInitializer:49)
java.lang.NullPointerException
        at org.apache.falcon.workflow.WorkflowJobEndNotificationService.init(WorkflowJobEndNotificationService.java:57)
        at org.apache.falcon.service.ServiceInitializer.initialize(ServiceInitializer.java:47)
        at org.apache.falcon.listener.ContextStartupListener.contextInitialized(ContextStartupListener.java:56)
        at org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:549)
        at org.mortbay.jetty.servlet.Context.startContext(Context.java:136)
        at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
        at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:518)
        at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
        at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
        at org.mortbay.jetty.Server.doStart(Server.java:224)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
        at org.apache.falcon.util.EmbeddedServer.start(EmbeddedServer.java:50)
        at org.apache.falcon.Main.main(Main.java:98)
2014-09-03 14:48:59,584 ERROR - [main:] ~ Failed startup of context org.mortbay.jetty.webapp.WebAppContext@38e993ad{/,/usr/lib/falcon/server/webapp/falcon} (log:87)
java.lang.RuntimeException: org.apache.falcon.FalconException: java.lang.NullPointerException
        at org.apache.falcon.listener.ContextStartupListener.contextInitialized(ContextStartupListener.java:59)
        at org.mortbay.jetty.handler.ContextHandler.startContext(ContextHandler.java:549)
        at org.mortbay.jetty.servlet.Context.startContext(Context.java:136)
        at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
        at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:518)
        at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
        at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
        at org.mortbay.jetty.Server.doStart(Server.java:224)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
        at org.apache.falcon.util.EmbeddedServer.start(EmbeddedServer.java:50)
        at org.apache.falcon.Main.main(Main.java:98)
Caused by: org.apache.falcon.FalconException: java.lang.NullPointerException
        at org.apache.falcon.service.ServiceInitializer.initialize(ServiceInitializer.java:50)
        at org.apache.falcon.listener.ContextStartupListener.contextInitialized(ContextStartupListener.java:56)
        ... 11 more
Caused by: java.lang.NullPointerException
        at org.apache.falcon.workflow.WorkflowJobEndNotificationService.init(WorkflowJobEndNotificationService.java:57)
        at org.apache.falcon.service.ServiceInitializer.initialize(ServiceInitializer.java:47)
        ... 12 more
2014-09-03 14:48:59,598 INFO  - [main:] ~ Started SocketConnector@0.0.0.0:15443 (log:67)