[FALCON-1804] Non-SLA feed throws NullPointerException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: trunk, 0.9
• Fix Version/s: 0.9
• Component/s: feed
• Assignee: sandeep samudrala
• Reporter: Pragya Mittal
• Created: 01/Feb/16 11:22
• Updated: 28/Feb/16 04:20
• Resolved: 05/Feb/16 12:15

Description

On scheduling a feed with no sla tag, NullPointerException is thrown. Following is the stacktrace :

2016-02-01 11:11:58,468 INFO  - [ActiveMQ Session Task-9:] ~ Removing Aa018f215-046cebba feed's instance Aa018f215-023c3659 in cluster null from pendingSLA (FeedSLA:270)
2016-02-01 11:11:58,468 ERROR - [ActiveMQ Session Task-9:] ~ Error in listener org.apache.falcon.handler.SLAMonitoringHandler (WorkflowJobEndNotificationService:252)
java.lang.NullPointerException
	at org.apache.falcon.service.FeedSLAMonitoringService.makeFeedInstanceAvailable(FeedSLAMonitoringService.java:273)
	at org.apache.falcon.handler.SLAMonitoringHandler.updateSLAMonitoring(SLAMonitoringHandler.java:63)
	at org.apache.falcon.handler.SLAMonitoringHandler.onSuccess(SLAMonitoringHandler.java:48)
	at org.apache.falcon.workflow.WorkflowJobEndNotificationService.notifyWorkflowEnd(WorkflowJobEndNotificationService.java:242)
	at org.apache.falcon.workflow.WorkflowJobEndNotificationService.notifySuccess(WorkflowJobEndNotificationService.java:102)
	at org.apache.falcon.messaging.JMSMessageConsumer.invokeListener(JMSMessageConsumer.java:218)
	at org.apache.falcon.messaging.JMSMessageConsumer.onMessage(JMSMessageConsumer.java:121)
	at org.apache.activemq.ActiveMQMessageConsumer.dispatch(ActiveMQMessageConsumer.java:1393)
	at org.apache.activemq.ActiveMQSessionExecutor.dispatch(ActiveMQSessionExecutor.java:131)
	at org.apache.activemq.ActiveMQSessionExecutor.iterate(ActiveMQSessionExecutor.java:202)
	at org.apache.activemq.thread.PooledTaskRunner.runTask(PooledTaskRunner.java:133)
	at org.apache.activemq.thread.PooledTaskRunner$1.run(PooledTaskRunner.java:48)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Feed definition is :

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<feed name="Aa018f215-046cebba" description="clicks log" xmlns="uri:falcon:feed:0.1">
    <frequency>minutes(10)</frequency>
    <timezone>UTC</timezone>
    <late-arrival cut-off="hours(6)"/>
    <clusters>
        <cluster name="Aa018f215-023c3659" type="source">
            <validity start="2009-01-01T01:00Z" end="2099-12-31T23:59Z"/>
            <retention limit="months(6)" action="delete"/>
        </cluster>
    </clusters>
    <locations>
        <location type="data" path="/tmp/falcon-regression/ProcessLateRerunTest/output-data/${YEAR}/${MONTH}/${DAY}/${HOUR}/${MINUTE}"/>
        <location type="stats" path="/projects/falcon/clicksStats"/>
        <location type="meta" path="/projects/falcon/clicksMetaData"/>
    </locations>
    <ACL owner="pragya" group="dataqa" permission="*"/>
    <schema location="/schema/clicks" provider="protobuf"/>
    <properties>
        <property name="field5" value="value1"/>
        <property name="field6" value="value2"/>
    </properties>
</feed>