Uploaded image for project: 'Falcon'
  1. Falcon
  2. FALCON-1597

Falcon should not retry in case of an instance being manual kill from user.

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.9
    • oozie, rerun
    • None

    Description

      As of now falcon doesn't distinguish between kill(failure in some form) and manual kill. In case of an instance being a manual kill, falcon should stop retrying on that instance.

      Attachments

        1. FALCON-1597.patch
          7 kB
          sandeep samudrala
        2. FALCON-1597-v1.patch
          7 kB
          sandeep samudrala
        3. FALCON-1597-v2.patch
          7 kB
          sandeep samudrala
        4. FALCON-1597-v3.patch
          7 kB
          sandeep samudrala
        5. FALCON-1597-v4.patch
          6 kB
          sandeep samudrala
        6. FALCON-1597-v5.patch
          6 kB
          sandeep samudrala

        Issue Links

          Activity

            pallavi.rao Pallavi Rao added a comment -

            +1. Patch looks good to me.

            Will wait 1 or 2 days for any further review comments before committing.

            pallavi.rao Pallavi Rao added a comment - +1. Patch looks good to me. Will wait 1 or 2 days for any further review comments before committing.
            ajayyadava Ajay Yadav added a comment -

            +1. Good catch sandeep.samudrala and thank you for fixing it.

            ajayyadava Ajay Yadav added a comment - +1. Good catch sandeep.samudrala and thank you for fixing it.

            sandeep.samudrala Patch looks good. out of curious how did you figure out oozie action has error code in case of failure through by example or looking into code base of oozie . Are you sure this always happen ?

            pavan kumar pavan kumar kolamuri added a comment - sandeep.samudrala Patch looks good. out of curious how did you figure out oozie action has error code in case of failure through by example or looking into code base of oozie . Are you sure this always happen ?
            pallavi.rao Pallavi Rao added a comment -

            Will commit in a bit.

            pallavi.rao Pallavi Rao added a comment - Will commit in a bit.

            pavan kumar: Yes, both checked via testing/examples and as per code too, error gets set for any case other than manual/user workflow/coordinator action kill.

            sandeep.samudrala sandeep samudrala added a comment - pavan kumar : Yes, both checked via testing/examples and as per code too, error gets set for any case other than manual/user workflow/coordinator action kill.
            pallavi.rao Pallavi Rao added a comment -

            To https://git-wip-us.apache.org/repos/asf/falcon.git
            0fe2762..f3b781d master -> master

            Thanks sandeep.samudrala for identifying and fixing the bug.

            pallavi.rao Pallavi Rao added a comment - To https://git-wip-us.apache.org/repos/asf/falcon.git 0fe2762..f3b781d master -> master Thanks sandeep.samudrala for identifying and fixing the bug.

            Thanks pallavi.rao ,ajayyadava , peeyushb and pavan kumar for reviewing and committing.

            sandeep.samudrala sandeep samudrala added a comment - Thanks pallavi.rao , ajayyadava , peeyushb and pavan kumar for reviewing and committing.

            People

              sandeep.samudrala sandeep samudrala
              sandeep.samudrala sandeep samudrala
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: