[EXEC-71] Changes for EXEC-34 (Race condition prevent watchdog working using ExecuteStreamHandler) hang endlessly if the command cannot be found

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.4.0
• Labels: patch
• Flags: Important
• Assignee: Siegfried Goeschl
• Reporter: Dominik Stadler
• Created: 09/Dec/12 17:58
• Updated: 09/Jan/16 17:27
• Resolved: 06/Jan/16 09:39

Description

The following test hangs endlessly for me because the ExecuteWatchdog will never get "processStarted = true" because starting an non-existing process will never lead to the started flag.

@Test
	public void testCommonsExecHang() throws Exception {
        CommandLine command = new CommandLine("someunexistingcommand");
        DefaultExecutor executor = new DefaultExecutor();

        ExecuteWatchdog watchdog = new ExecuteWatchdog(ExecuteWatchdog.INFINITE_TIMEOUT);
        executor.setWatchdog(watchdog);

        DefaultExecuteResultHandler resultHandler = new DefaultExecuteResultHandler() {
			@Override
			public void onProcessFailed(ExecuteException e) {
		        System.out.println("Process did not stop gracefully, had exception '" + e.getMessage() + "' while executing process");
				super.onProcessFailed(e);
			}
        };

        executor.execute(command, null, resultHandler);

        // this hangs!!
        watchdog.isWatching();

        watchdog.destroyProcess();
	}

not calling isWatching(), but only destroyProcess() hangs as well!

Options that I see: timeout the loop or handle the case of failure to start the Watchdog in DefaultExecutor.executeInternal() so that the Watchdog does not hang in this case

Issue Links

• is broken by: EXEC-34 Race condition prevent watchdog working using ExecuteStreamHandler