Commons Exec
  1. Commons Exec
  2. EXEC-41

Patch to enable executing thread to return immediately when process is "killed" by a watchdog

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.0, 1.1
    • Fix Version/s: 1.1
    • Labels:
      None
    • Environment:

      Windows XP

      Description

      This has been discussed on the commons-users mailing list. The patch intends to solve the following problem:
      when a process runs longer than allowed by a configured watchdog's timeout, the watchdog tries to destroy it and then DefaultExecutor tries to clean up by joining with all installed pump stream threads. Problem is, that sometimes the native process doesn't die and thus streams aren't closed and the stream threads do not complete.

      The patch provides setAlwaysWaitForStreamThreads(boolean) method in PumpStreamHandler. By default, alwaysWaitForStreamThreads is set to true to preserve the current behavior. If set to false, and process is killed by watchdog, DefaultExecutor's call into ErrorStreamHandler.stop will NOT join the stream threads and DefaultExecutor will NOT attempt to close the streams, so the executor's thread won't get stuck.

      Additionally, this patch fixes a small but annoying bug in DefaultExecuteHandler.setExitValues(int[])

      1. commons-exec.patch
        6 kB
        Ernest Mishkin
      2. EXEC-41.patch
        5 kB
        Siegfried Goeschl

        Activity

        Ernest Mishkin created issue -
        Ernest Mishkin made changes -
        Field Original Value New Value
        Attachment commons-exec.patch [ 12412097 ]
        Siegfried Goeschl made changes -
        Assignee Siegfried Goeschl [ sgoeschl ]
        Siegfried Goeschl made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Siegfried Goeschl made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Siegfried Goeschl made changes -
        Attachment EXEC-41.patch [ 12452108 ]
        Siegfried Goeschl made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Siegfried Goeschl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Siegfried Goeschl
            Reporter:
            Ernest Mishkin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development