[ETCH-275] ValueFactory SRuntimes Mutex not unlocked

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.4.0
• Component/s: binding-cpp
• Environment: All
• Assignee: Martin Veith
• Reporter: Aaron Frueh
• Created: 19/Nov/13 12:13
• Updated: 21/Mar/14 09:00
• Resolved: 03/Dec/13 08:20

Description

(Code Generation)
The Static SRuntimes Mutex is not unlocked on every Error-Case and resolves to deadlocks.

See following example:

status_t ValueFactoryRemoting::InitValueFactory(EtchRuntime* runtime)
{
status_t status;
SRuntimesMutex.lock();
if (SRuntimes.find(runtime->getId()) != SRuntimes.end())

{ //runtime is already in list return ETCH_OK; <=== Missing unlock }

status = SRuntimes.push_back(runtime->getId());
runtime->registerListener(&SRemotingRuntimeListener);
if (status != ETCH_OK)

{ return status; // <=== Missing unlock }

if (SRuntimes.size() > 1)

{ //Valuefactory is already initialized SRuntimesMutex.unlock(); return ETCH_OK; }

SRuntimesMutex.unlock();