[ETCH-25] DefaultDeliveryService ends call with mb.CloseDelivery() and it should end it with mb.CloseRead()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.0.1
• Fix Version/s: 1.0.2
• Component/s: binding-csharp, binding-java
• Assignee: Robert Scott Comer
• Reporter: Robert Scott Comer
• Created: 14/Jan/09 15:27
• Updated: 26/Sep/13 08:31
• Resolved: 20/Jan/09 23:25

Description

when done reading the mailbox, the right method to call is CloseRead(). somehow the code actually calls CloseDelivery(), a method used to shutdown the writing side of the mailbox. CloseRead() calls CloseDelivery() first off, but then takes the additional steps of redelivering any messages left in the mailbox.

The distinction is rather fine, and this bug was found by reading the source code. There are certain ways you could exercise this bug, but it would be very rare and not have any real impact. So, it isn't an emergency to fix it, but it is also a relatively benign fix. I've already made the change in my tree and tested it. The patch is attached.