Commons Email
  1. Commons Email
  2. EMAIL-76

Some setters of class Email does not return "this".

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Labels:
      None

      Description

      Some setters of class Email return "this", and some doesn't.
      For the consistency, all the setters should return "this".

      1. MultiPartEmailSetter.patch
        3 kB
        Yu Kobayashi
      2. EmailSetter.patch
        8 kB
        Yu Kobayashi

        Activity

        Yu Kobayashi created issue -
        Hide
        Yu Kobayashi added a comment -

        I created a patch for this problem.

        Show
        Yu Kobayashi added a comment - I created a patch for this problem.
        Yu Kobayashi made changes -
        Field Original Value New Value
        Attachment EmailSetter.patch [ 12379992 ]
        Hide
        Yu Kobayashi added a comment -

        I also created similar patch for the class MultiPartEmail.

        Original MultiPartEmail.addPart() downcasts the return value from MultiPartEmail to Email. This is not necessary. I change it to return MultiPartEmail.

        Show
        Yu Kobayashi added a comment - I also created similar patch for the class MultiPartEmail. Original MultiPartEmail.addPart() downcasts the return value from MultiPartEmail to Email. This is not necessary. I change it to return MultiPartEmail.
        Yu Kobayashi made changes -
        Attachment MultiPartEmailSetter.patch [ 12379993 ]
        Siegfried Goeschl made changes -
        Assignee Siegfried Goeschl [ sgoeschl ]
        Siegfried Goeschl made changes -
        Fix Version/s 1.3 [ 12315052 ]
        Siegfried Goeschl made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Siegfried Goeschl made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Thomas Neidhart made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Siegfried Goeschl
            Reporter:
            Yu Kobayashi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development