Commons Email
  1. Commons Email
  2. EMAIL-75

Email.setFrom, addTo should use Email.charset

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Labels:
      None

      Description

      Email.addTo() and setFrom() doesn't use Email.charset.

      Code should be as following.

      public Email setFrom(String email, String name)
      throws EmailException
      {
      return setFrom(email, name, this.charset);
      }

      public Email addTo(String email, String name)
      throws EmailException
      {
      return addTo(email, name, this.charset);
      }

        Activity

        Yu Kobayashi created issue -
        Yu Kobayashi made changes -
        Field Original Value New Value
        Description Email.addTo() and setFrom() doesn't use Email.charset.

        Code should be as following.

            public Email setFrom(String email, String name)
                throws EmailException
            {
                return setFrom(email, name, this.charset);
            }

            public Email addTo(String email, String name)
                throws EmailException
            {
                return addTo(email, name, this.charset);
            }
        Email.addTo() and setFrom() doesn't use Email.charset.

        Code should be as following.

        public Email setFrom(String email, String name)
            throws EmailException
        {
            return setFrom(email, name, this.charset);
        }

        public Email addTo(String email, String name)
            throws EmailException
        {
            return addTo(email, name, this.charset);
        }
        Hide
        Ben Speakmon added a comment -

        Agree. Can you provide a patch against the trunk?

        Show
        Ben Speakmon added a comment - Agree. Can you provide a patch against the trunk?
        Hide
        Yu Kobayashi added a comment - - edited

        I created a patch for this issue.

        Show
        Yu Kobayashi added a comment - - edited I created a patch for this issue.
        Yu Kobayashi made changes -
        Attachment EmailCharset.patch [ 12379989 ]
        Siegfried Goeschl made changes -
        Assignee Siegfried Goeschl [ sgoeschl ]
        Siegfried Goeschl made changes -
        Fix Version/s 1.2 [ 12313573 ]
        Hide
        Siegfried Goeschl added a comment -

        Will be part of the 1.2 release

        Show
        Siegfried Goeschl added a comment - Will be part of the 1.2 release
        Siegfried Goeschl made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Siegfried Goeschl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Siegfried Goeschl
            Reporter:
            Yu Kobayashi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development