Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Nightly Builds
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      Operating System: other
      Platform: Other

      Description

      There were inconsistencies in the style (a lot caused by my unit
      tests...sorry). All changes provided are style only no functionality changes.

      The style applied is Turbine (as much as possible)

        Activity

        Hide
        Corey Scott added a comment -

        Created an attachment (id=13214)
        style only changes (deprecated class have been ignored)

        Show
        Corey Scott added a comment - Created an attachment (id=13214) style only changes (deprecated class have been ignored)
        Hide
        Corey Scott added a comment -

        Created an attachment (id=13215)
        Incase anyone else uses eclipse and wants the style file (and doesnt already have one, here it is)

        Show
        Corey Scott added a comment - Created an attachment (id=13215) Incase anyone else uses eclipse and wants the style file (and doesnt already have one, here it is)
        Hide
        David Eric Pugh added a comment -

        I just want to reconfirm that this is the standard "sun" format? And, have you
        tried to run the checkstyle report? I just reactivated it.. It should report
        no results too...

        Show
        David Eric Pugh added a comment - I just want to reconfirm that this is the standard "sun" format? And, have you tried to run the checkstyle report? I just reactivated it.. It should report no results too...
        Hide
        David Eric Pugh added a comment -

        also, not sure you did it quite against CVS HEAD. Most applies, but not all!

        Show
        David Eric Pugh added a comment - also, not sure you did it quite against CVS HEAD. Most applies, but not all!
        Hide
        David Eric Pugh added a comment -

        Okay, I committed what applied. From 800 and some odd errors to 300 and some odd!

        Show
        David Eric Pugh added a comment - Okay, I committed what applied. From 800 and some odd errors to 300 and some odd!
        Hide
        Corey Scott added a comment -

        I checkout against the HEAD and then applied the changes.

        I didnt use the Sun style, I used the Turbine style as stated in the previous
        message. I also have attached to this bug a style document for checkstyle for
        the Turbine standard. There should only be about 20 odd violations, I am
        happy to change these as well but some changes will amount to 'refactoring'
        small chunks of code.
        There is one that concerns the amount of params to a method (max 7 says the
        checker), I am not sure what to do about this.
        There is another that is a line longer than 80 chars, this one I cant find
        anyway to reformat as its a CVS header (i think)

        Please let me know what more you would like to do to get us to where we need
        to be. Thanks

        Show
        Corey Scott added a comment - I checkout against the HEAD and then applied the changes. I didnt use the Sun style, I used the Turbine style as stated in the previous message. I also have attached to this bug a style document for checkstyle for the Turbine standard. There should only be about 20 odd violations, I am happy to change these as well but some changes will amount to 'refactoring' small chunks of code. There is one that concerns the amount of params to a method (max 7 says the checker), I am not sure what to do about this. There is another that is a line longer than 80 chars, this one I cant find anyway to reformat as its a CVS header (i think) Please let me know what more you would like to do to get us to where we need to be. Thanks
        Hide
        Corey Scott added a comment -

        Created an attachment (id=13224)
        style only changes for deprecated class ByteArrayDataSouce

        Show
        Corey Scott added a comment - Created an attachment (id=13224) style only changes for deprecated class ByteArrayDataSouce
        Hide
        Corey Scott added a comment -

        Changes for last attachment (10/26/04 18:31)
        ByteArrayDataSource
        ---------------------
        -Minor style changes
        -Removed redunant try/catch blocks from:
        byteArrayDataSource(InputStream aIs, String aType)
        ByteArrayDataSource(byte[] data, String aType)
        ByteArrayDataSource(String data, String aType)
        -Changed the empty catch (UnsupportedEncodingException uex),
        which is an coding style violation, to throw an IOException
        -Changed the line "byte[] buffer = new byte[512];"
        in byteArrayDataSource(InputStream aIs, String aType) to a static property
        again to conform to the coding style

        Show
        Corey Scott added a comment - Changes for last attachment (10/26/04 18:31) ByteArrayDataSource --------------------- -Minor style changes -Removed redunant try/catch blocks from: byteArrayDataSource(InputStream aIs, String aType) ByteArrayDataSource(byte[] data, String aType) ByteArrayDataSource(String data, String aType) -Changed the empty catch (UnsupportedEncodingException uex), which is an coding style violation, to throw an IOException -Changed the line "byte[] buffer = new byte [512] ;" in byteArrayDataSource(InputStream aIs, String aType) to a static property again to conform to the coding style
        Hide
        David Eric Pugh added a comment -

        Corey, I think I had previously applied this patch for ByteArrayDataSource.

        Show
        David Eric Pugh added a comment - Corey, I think I had previously applied this patch for ByteArrayDataSource.

          People

          • Assignee:
            Unassigned
            Reporter:
            Corey Scott
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development