[EMAIL-207] Don't waste memory in MimeMessageParser#createDataSource()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5
• Fix Version/s: 1.6.0
• Assignee: Unassigned
• Reporter: Jaeheon-Lee
• Created: 07/Aug/23 13:33
• Updated: 02/May/24 15:46
• Resolved: 10/Dec/23 20:27

Description

Found

Hello.

OOM occurred in the mail service developed using Apache-commons-email.

I debugged and found that the mail lookup function was wasting memory!

Problem

Below is a test for reproducing the problem.

@Test
void memoryTest() throws Exception {
    FileInputStream is = new FileInputStream("/test/oom.eml");
    Session session = Session.getInstance(System.getProperties());
    MimeMessage mimeMessage = new MimeMessage(session, is);
    MimeMessageParser parser = new MimeMessageParser(mimeMessage).parse();
} 

Below is the memory usage.

 

I was thinking of using Attachments as a buffer for OutputStream when I really need them.

However, it is becoming a problem by putting all bytes[] in memory.

 

Thanks.

Issue Links

• causes: EMAIL-209 InputStreamDataSource#getInputStream() violates javax.activation.DataSource contract
• links to: GitHub Pull Request #159