[EMAIL-167] DataSourceClassPathResolver doesn't close InputStream when resolving resources

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5
• Assignee: Unassigned
• Reporter: Lucian Burja
• Created: 23/Feb/17 15:37
• Updated: 16/Mar/17 00:38
• Resolved: 16/Mar/17 00:38

Description

DataSourceClassPathResolver opens an InputStream (via .class.getResourceAsStream) to read a resource into a ByteArrayDataSource, but never closes it:

    public DataSource resolve(final String resourceLocation, final boolean isLenient) throws IOException
    {
...
                final InputStream is = DataSourceClassPathResolver.class.getResourceAsStream(resourceName);

                if (is != null)
                {
                    final ByteArrayDataSource ds = new ByteArrayDataSource(is, mimeType);
                    // EMAIL-125: set the name of the DataSource to the normalized resource URL
                    // similar to other DataSource implementations, e.g. FileDataSource, URLDataSource
                    ds.setName(DataSourceClassPathResolver.class.getResource(resourceName).toString());
                    result = ds;
                }

The 'is' variable above should be closed in a try ... finally