Uploaded image for project: 'Commons Email'
  1. Commons Email
  2. EMAIL-151

ImageHtmlEmail uses wrong name for embed() call

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.3
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      Found by reading the code: ImageHtmlEmail#replacePattern() asks the DataSourceResolver for a DataSource, and if the name of the data source is null/empty uses the resource location as name for looking up the CID.

      But, if that didn't work out it tries to embed the data source using the original 'null' name instead, which fails with an exception.

      Trivial patch attached.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ankon Andreas Kohn
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: