Commons Email
  1. Commons Email
  2. EMAIL-135

Make DataSourceUrlResolver#createUrl() protected

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 1.3.1
        • Fix Version/s: 1.3.2
        • Labels:
          None

          Description

          It would be nice if #createUrl() was protected, so that it can be used in derived classes.

          In the specific instance where I need that: we're sending emails using Amazon Simple Email Service, which requires that attachments not just have a specific content type, but also an extension matching that content type.

          To implement this requirement I've extended DataSourceUrlResolver, and return a URLDataSource that reports the original file name with the extension suitably enforced.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Andreas Kohn added a comment -

            Trivial patch.

            Show
            Andreas Kohn added a comment - Trivial patch.
            Hide
            Permalink
            Thomas Neidhart added a comment -

            Sounds reasonable, applied change in r1532538.

            Thanks for the report and patch!

            Show
            Thomas Neidhart added a comment - Sounds reasonable, applied change in r1532538. Thanks for the report and patch!

              People

              • Assignee:
                Unassigned
                Reporter:
                Andreas Kohn
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development