Commons Email
  1. Commons Email
  2. EMAIL-111

Update the current trunk to be binary compatible with the commons-email-1.2 release

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Labels:
      None

      Description

      The last RC was rejected because the RC is not binary compatible with commons-email-1.2

      • some getter methods return "Email" instead of "void" which breaks binary compatibility
      • two protected member variable (SSL & TLS related) were removed since their name was misleading

      The goals of the task is to get rid of those Clirr warnings in order to avoid a new major release

      1. sslTls.diff
        3 kB
        Florian Pirchner
      2. returntypes.diff
        9 kB
        Florian Pirchner

        Activity

        Hide
        Sebb added a comment -

        The method MultiPartEmail#addPart(String, String) was changed to return MultiPartEmail rather than Email.

        That also needs to be reverted.

        [Reminder: re-open any JIRA fixes that had to be reverted; also update release notes/changes]

        Show
        Sebb added a comment - The method MultiPartEmail#addPart(String, String) was changed to return MultiPartEmail rather than Email. That also needs to be reverted. [Reminder: re-open any JIRA fixes that had to be reverted; also update release notes/changes]
        Hide
        Siegfried Goeschl added a comment -

        You are absolutely right ... thx Sebastian

        Show
        Siegfried Goeschl added a comment - You are absolutely right ... thx Sebastian
        Hide
        Florian Pirchner added a comment -

        Two patches provided by hackergarten vienna.

        Best,
        Flo and Peter

        Show
        Florian Pirchner added a comment - Two patches provided by hackergarten vienna. Best, Flo and Peter
        Hide
        Siegfried Goeschl added a comment -

        Applied patch to trunk

        Show
        Siegfried Goeschl added a comment - Applied patch to trunk

          People

          • Assignee:
            Siegfried Goeschl
            Reporter:
            Siegfried Goeschl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development