[EMAIL-106] STARTTLS is only enabled if an authenticator is used

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3
• Assignee: Siegfried Goeschl
• Reporter: Bruno Harbulot
• Created: 17/Jul/11 18:42
• Updated: 11/Jan/13 15:47
• Resolved: 06/Sep/11 20:40

Description

The STARTTLS parameter is only set if an authenticator is used, whereas the two features are independent: it would also make sense to use STARTTLS without authentication, so as to protect eavesdropping of the e-mail content, for example.

Here is a patch for src/java/org/apache/commons/mail/Email.java (rev. 1088801):

@@ -481,9 +481,9 @@ public abstract class Email implements EmailConstants
             properties.setProperty(MAIL_HOST, this.hostName);
             properties.setProperty(MAIL_DEBUG, String.valueOf(this.debug));
 
+            properties.setProperty(MAIL_TRANSPORT_TLS, tls ? "true" : "false");
             if (this.authenticator != null)
             {
-                properties.setProperty(MAIL_TRANSPORT_TLS, tls ? "true" : "false");
                 properties.setProperty(MAIL_SMTP_AUTH, "true");
             }