Commons Email
  1. Commons Email
  2. EMAIL-103

Plain email addresses always have a name set

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Labels:
      None

      Description

      With commons email, it always sets the "name" of the email address to the email address when it is not passed in or is blank. This results in address fields looking like this (using From as an example):

      From: "example@example.com" <example@example.com>

      When I would expect them to look like this:

      From: example@example.com

      It seems that there is no real reason to do this. At the very least, it would be nice to have the option to not have this set.

      The affected file is org/apache/commons/mail/Email.java in function createInternetAddress. I will attach one possible solution.

      1. Email.patch
        1 kB
        David Rees

        Activity

        Hide
        Siegfried Goeschl added a comment -

        When not setting the personal name we got 12 errors for the JUnit test - I propose to get a the next release out before applying the patch and fixing the regression tests

        Show
        Siegfried Goeschl added a comment - When not setting the personal name we got 12 errors for the JUnit test - I propose to get a the next release out before applying the patch and fixing the regression tests
        Hide
        Thomas Neidhart added a comment -

        Applied patch together with unit test fixes in r1418735.

        Thanks for the report and patch!

        Show
        Thomas Neidhart added a comment - Applied patch together with unit test fixes in r1418735. Thanks for the report and patch!

          People

          • Assignee:
            Siegfried Goeschl
            Reporter:
            David Rees
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development