Droids
  1. Droids
  2. DROIDS-143

Validators are no longer used by the crawling process

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.1.0
    • Component/s: core
    • Labels:
      None

      Description

      The patch for DROIDS-56 has removed the validation from the crawling process. See discussion on DROIDS-56 for more details.

      1. DROIDS-143.patch
        16 kB
        Eugen Paraschiv

        Activity

        Eugen Paraschiv created issue -
        Eugen Paraschiv made changes -
        Field Original Value New Value
        Attachment DROIDS-143.patch [ 12480160 ]
        Hide
        Richard Frovarp added a comment -

        I think I'm missing something. Isn't there a unit test in there indicating that the existing code does limit crawl depth? Or is that just something that doesn't get passed up to a usable level?

        Show
        Richard Frovarp added a comment - I think I'm missing something. Isn't there a unit test in there indicating that the existing code does limit crawl depth? Or is that just something that doesn't get passed up to a usable level?
        Hide
        Eugen Paraschiv added a comment -

        There indeed was a very small and simple test that checked if a validator would accept or reject a task based on the depth, which still works, but there was no test to say that the validator is actually used or not. And since the validators are all there, the test passes fine, but they're just not used at all now. I'll try to add some tests in this area in 0.2.

        Show
        Eugen Paraschiv added a comment - There indeed was a very small and simple test that checked if a validator would accept or reject a task based on the depth, which still works, but there was no test to say that the validator is actually used or not. And since the validators are all there, the test passes fine, but they're just not used at all now. I'll try to add some tests in this area in 0.2.
        Hide
        Richard Frovarp added a comment -

        Patch applied in r1127244. Thanks.

        Show
        Richard Frovarp added a comment - Patch applied in r1127244. Thanks.
        Eugen Paraschiv made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Eugen Paraschiv made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 1h 11m 1 Eugen Paraschiv 24/May/11 21:58
        Resolved Resolved Closed Closed
        5s 1 Eugen Paraschiv 24/May/11 21:58

          People

          • Assignee:
            Unassigned
            Reporter:
            Eugen Paraschiv
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development