Uploaded image for project: 'Droids'
  1. Droids
  2. DROIDS-123

Better formatting consistency for the Droids codebase

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 0.2.0
    • 0.3.0
    • core
    • None

    Description

      The formatting in droids should effectively be the same as the standard Java Conventions build in Eclipse formatter. However, the are multiple formatting inconsistencies in the droids codebas.
      Examples:
      1. braces

      • SimpleTaskQueue - even in the same class, there are cases where the opening braces are on the same line as the method signature:
        public T next() {
        and cases where they are not:
        public void clear()
        {

      2. whitespace

      • sometimes there is a whitespace between a 'for' and the '('
        for (
        and sometimes there is not:
        for(

      The proposal to deal with this is to start with the Java build in formatter in Eclipse (with a few minor changes), and format the entire droids codebase - the changes should be minor in most cases.

      Attachments

        1. DROIDS-123_step1_v1.patch
          78 kB
          Eugen Paraschiv
        2. DROIDS-123_step2_v1.patch
          29 kB
          Eugen Paraschiv
        3. DROIDS-123-introducing-jalopy.patch
          9 kB
          Bertil Chapuis
        4. eclipse-java-profile.xml
          28 kB
          Thorsten Scherler

        Activity

          People

            tobr Tobias Rübner
            eugenparaschiv Eugen Paraschiv
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: