[DRILL-8302] tidy up some char conversions

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.21.0
• Assignee: PJ Fanning
• Reporter: PJ Fanning
• Created: 08/Sep/22 10:19
• Updated: 27/Dec/22 10:11
• Resolved: 27/Dec/22 10:11

Description

As part of DRILL-8301, I spotted code that could be tidied up. The aim of this issue is to reduce the size of DRILL-8301 without introducing changes to the char encodings.

• uses of a pattern like `new String("aaaa")` - IntelliJ and other tools highlight this as unnecessary
• uses of `new String(bytes, StandardCharsets.UTF_8.name())` - better to use `new String(bytes, StandardCharsets.UTF_8)`
• use Base64 encodeToString instead of case where we encode to bytes and then do our own encoding of those bytes to a String
• Change existing code with `Charset.forName("UTF-8")` to use `StandardCharsets.UTF_8`

Issue Links

• relates to: DRILL-8301 Standardise on UTF-8 encoding for char to byte (and vice versa) conversions