[DRILL-8049] Make rule names for Iceberg plugin instances unique

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.20.0
• Fix Version/s: 1.20.0
• Assignee: Vova Vysotskyi
• Reporter: Vova Vysotskyi
• Created: 19/Nov/21 16:59
• Updated: 20/Nov/21 11:32
• Resolved: 20/Nov/21 11:32

Description

As dzamo noticed, when defining multiple storage plugins with Iceberg format, queries fail with the following error:

Caused by: java.lang.AssertionError: Rule's description should be unique; existing rule=VertexDrelConverterRuleICEBERG.iceberg(in:ICEBERG.iceberg,out:LOGICAL); new rule=VertexDrelConverterRuleICEBERG.iceberg(in:ICEBERG.iceberg,out:LOGICAL)
        at org.apache.calcite.plan.AbstractRelOptPlanner.mapRuleDescription(AbstractRelOptPlanner.java:152)
        at org.apache.calcite.plan.volcano.VolcanoPlanner.addRule(VolcanoPlanner.java:459)
        at org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:315)
        at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:405)
        at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:351)
        at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRawDrel(DefaultSqlHandler.java:245)
        at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToDrel(DefaultSqlHandler.java:308)
        at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:173)
        at org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:283)
        at org.apache.drill.exec.planner.sql.DrillSqlWorker.getPhysicalPlan(DrillSqlWorker.java:163)
        at org.apache.drill.exec.planner.sql.DrillSqlWorker.convertPlan(DrillSqlWorker.java:128)
        at org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:93)
        at org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:593)
        at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:274)
        ... 1 common frames omitted