[DRILL-7639] Replace DBCP2 with HikariCP in RDBMS (JDBC) plugin

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Labels: doc-impacting ready-to-commit
• Assignee: Arina Ielchiieva
• Reporter: Arina Ielchiieva
• Reviewer: Vova Vysotskyi
• Created: 12/Mar/20 14:33
• Updated: 16/Mar/20 16:23
• Resolved: 16/Mar/20 09:46

Description

Hikari is much faster and more reliable than DBCP2.
See comparison and benchmarks:
https://beansroasted.wordpress.com/2017/07/29/connection-pool-analysis/
https://github.com/brettwooldridge/HikariCP

sourceParameters section will allow setting data source parameters listed in https://github.com/brettwooldridge/HikariCP

Example:

    "sourceParameters" : {
        "minimumIdle" : 5,
        "autoCommit": false,
        "connectionTestQuery": "select * from information_schema.collations",
        "dataSource.cachePrepStmts": true,
        "prepStmtCacheSize": 250
      }

Example of full configuration:

{
  "type": "jdbc",
  "driver": "org.postgresql.Driver",
  "url": "jdbc:postgresql://localhost:5959/my_db?defaultRowFetchSize=2",
  "username": "my_user",
  "password": "my_pass",
  "caseInsensitiveTableNames": false,
  "sourceParameters": {
    "autoCommit": false
  },
  "enabled": true
}

Issue Links

• links to: GitHub Pull Request #2027