[DRILL-7612] Modify the Text, Excel format config, etc. immutable

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 27/Feb/20 03:01
• Updated: 12/Apr/20 00:25

Description

See note in the ExcelFormatConfig class. The class is designed with mutable fields. However, if any of the fields are actually changed while the excel reader pluguin is active, the result is undefined. This is true, by the way, for all storage and plugin configs.

Would be better for the class to be immutable with final fields. By doing this it becomes impossible for uninformed code to grab a config from the plugin registry, modify it, and put it back, causing the registry to become confused due to its value-based config map.

Issue Links

• relates to: DRILL-6672 Drill table functions cannot handle "setFoo" accessors