[DRILL-7401] Sqlline 1.9 upgrade

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.17.0
• Labels: ready-to-commit
• Assignee: Arina Ielchiieva
• Reporter: Arina Ielchiieva
• Reviewer: Vova Vysotskyi
• Created: 11/Oct/19 12:15
• Updated: 21/Oct/19 13:06
• Resolved: 21/Oct/19 13:06

Description

Upgrade to SqlLine 1.9 once it is released (https://github.com/julianhyde/sqlline/issues/350).

TODO:
1. Add SqlLine properties:
connectInteractionMode: useNPTogetherOrEmpty - supports connection mehanism used in SqlLine 1.17 and earlier:
a. if user and password are not indicated, connects without them (user and password are set t empty string): ./drill-embedded
b. if user is indicated, asks for password in interactive mode: ./drill-embedded -n "user1"
c. if user is indicated as empty string, behaives like in point a (user and password are set t empty string): ./drill-embedded -n ""
d. if user and password are indicated, connects using provided input ./drill-embedded -n "user1" -p "123"

showLineNumbers: true - adds line numbers when query is more than one line:

apache drill> select
2..semicolon> *
3..semicolon> from
4..semicolon> sys.version;

2. Remove nohup support code from sqlline.sh since it is not needed any more (nohup support wroks without flag):

To add nohup support for SQLline script
if [[ ( ! $(ps -o stat= -p $$) =~ "+" ) && ! ( -p /dev/stdin ) ]]; then
   export SQLLINE_JAVA_OPTS="$SQLLINE_JAVA_OPTS -Djline.terminal=jline.UnsupportedTerminal"
fi

3. Add -Dorg.jline.terminal.dumb=true to avoid JLine terminal warning when submitting query in sqlline.sh to execute via -e or -f:

Oct 11, 2019 2:14:45 PM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)

4. Remove unneeded echo commands in sqlline.bat during start up:

drill-embedded.bat
DRILL_ARGS - " -u jdbc:drill:zk=local -n user1 -p ppp"
Calculating HADOOP_CLASSPATH ...
HBASE_HOME not detected...
Calculating Drill classpath...
Apache Drill 1.17.0-SNAPSHOT
"Data is the new oil. Ready to Drill some?"
apache drill>

Issue Links

• is related to: DRILL-3850 Execute multiple commands from sqlline -q
• relates to: DRILL-5436 Need a way to input password which contains space when calling sqlline
• links to: GitHub Pull Request #1875