Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-7393

Revisit Drill tests to ensure that patching is executed before any test run

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.16.0, 1.17.0
    • Fix Version/s: 1.17.0
    • Component/s: None
    • Labels:

      Description

      Apache Drill patches some Protobuf and Guava classes (see GuavaPatcher, ProtobufPatcher), patching should be done before classes to be patched are loaded. That's why this operation is executed in static block in Drillbit class.

      Some tests in java-exec module use Drillbit class, some extend DrillTest class, both of them patch Guava. But there are some tests that do not call patcher but load classes to be patched. For example, org.apache.drill.exec.sql.TestSqlBracketlessSyntax loads Guava Preconditions class. If such tests run before tests that require patching, tests run will fail since patching won't be successful. Patchers code does not fail application if patching was not complete, just logs warning (logger.warn("Unable to patch Guava classes.", e);), so sometimes it hard to identify unit tests failure root cause.

      We need to revisit all Drill tests to ensure that all of them extend common test base class which patchers Protobuf and Guava classes in static block. Also refactor Patcher classes to have assert to fail if patching fails during unit testing if there are any problems.

      After all tests are revised, we can remove metastore-test execution from main.xml in maven-surefire-plugin which was added to ensure that all Metastore tests run in a separate JVM where patching is done in first place since Iceberg Metastore heavily depends on patched Guava Preconditions class.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                angozhiy Anton Gozhiy
                Reporter:
                arina Arina Ielchiieva
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: