Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-7024

Refactor ColumnWriter to simplify type-conversion shim

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.15.0
    • 1.16.0
    • None

    Description

      DRILL-7006 added a type conversion "shim" within the row set framework. Basically, we insert a "shim" column writer that takes data in one form (String, say), and does reader-specific conversions to a target format (INT, say).

      The code works fine, but the shim class ends up needing to override a bunch of methods which it then passes along to the base writer.

      This ticket asks to refactor the code so that the conversion shim is simpler.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Paul.Rogers Paul Rogers
            Paul.Rogers Paul Rogers
            Arina Ielchiieva Arina Ielchiieva
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment