[DRILL-7024] Refactor ColumnWriter to simplify type-conversion shim

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.16.0
• Labels: ready-to-commit
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Reviewer: Arina Ielchiieva
• Created: 02/Feb/19 03:47
• Updated: 08/Feb/19 10:44
• Resolved: 08/Feb/19 10:44

Description

DRILL-7006 added a type conversion "shim" within the row set framework. Basically, we insert a "shim" column writer that takes data in one form (String, say), and does reader-specific conversions to a target format (INT, say).

The code works fine, but the shim class ends up needing to override a bunch of methods which it then passes along to the base writer.

This ticket asks to refactor the code so that the conversion shim is simpler.

Issue Links

• links to: GitHub Pull Request #1633