[DRILL-6903] SchemaBuilder improvements

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.16.0
• Fix Version/s: 1.16.0
• Labels: ready-to-commit
• Assignee: Arina Ielchiieva
• Reporter: Arina Ielchiieva
• Reviewer: Paul Rogers
• Created: 13/Dec/18 13:17
• Updated: 14/Jan/19 09:03
• Resolved: 14/Jan/19 09:03

Description

SchemaBuilder code will be moved to the exec package from test in DRILL-6901.
There are a couple of improvements that can be done in the existing code:

1. ColumnBuilder: setScale method
setScale method is a bit awkward, it requires precision as second parameter. More natural to go with precision and then scale.
Suggestion is to have setPrecisionAndScale method instead which will accept precision and scale as first and second parameters.
https://github.com/apache/drill/blob/master/exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/ColumnBuilder.java#L57

2. SchemaContainer: addColumn method
addColumn method has parameter AbstractColumnMetadata, since we have interface ColumnMetadata, it's better to operate on the interface level rather than on the abstract class.
https://github.com/apache/drill/blob/master/exec/java-exec/src/test/java/org/apache/drill/test/rowSet/schema/SchemaContainer.java#L28

3. MapBuilder / RepeatedListBuilder / UnionBuilder: buildCol method
buildCol method is private in these classes. These classes create columns and add them to the schema. There might be use cases when dev needs only column and will add it to the schema when needed. Suggestion is to make buildCol method public. Also all these classes require SchemaContainer as parent, though when we only need them to build the column, second constructor can be added without SchemaContainer parameter.

Issue Links

• is required by: DRILL-6835 Schema Provision using File / Table Function
• links to: GitHub Pull Request #1599