Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-6788

Intermittent unit test failure TestDrillbitResilience.failsWhenParsing: Query state should be FAILED (and not COMPLETED)

    Details

      Description

      I am seeing a unit test failing for me consistently on master. On further debugging I think the root cause is because of a change done as part of below commit for DRILL-6762.
      https://github.com/apache/drill/commit/2bd26ffe34108f876184c63188122f2d49db4c4a
       
      Failing Test:

      13:35:30.914 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 B(65.0 KiB), h: 33.0 MiB(2.2 GiB), nh: 56.3 KiB(304.1 MiB)): failsWhenParsing(org.apache.drill.exec.server.TestDrillbitResilience) java.lang.AssertionError: Query state should be FAILED (and not COMPLETED). at org.apache.drill.exec.server.TestDrillbitResilience.assertFailsWithException(TestDrillbitResilience.java:730) ~[test-classes/:na] at org.apache.drill.exec.server.TestDrillbitResilience.assertFailsWithException(TestDrillbitResilience.java:736) ~[test-classes/:na] at org.apache.drill.exec.server.TestDrillbitResilience.failsWhenParsing(TestDrillbitResilience.java:748) ~[test-classes/:na] at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_161]

       
      TestDrillbitResilience.failsWhenParsing:748->assertFailsWithException:736->assertFailsWithException:730 Query state should be FAILED (and not COMPLETED).
       
      Root Cause:
      The test basically set's up an injection to be triggered during parsing and only throw checked exception once. With this new change it catches the throw'd exception and retries. Since the injector has already thrown the exception before upon retry it doesn't inject another exception and the query is fine.
       
      Fix:
      We can fix this by increasing the number of throws by injector to 2 instead of 1 so upon retry the exception will be thrown again. 

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                shamirwasia Sorabh Hamirwasia
                Reporter:
                shamirwasia Sorabh Hamirwasia
                Reviewer:
                Arina Ielchiieva
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: