Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-6438

Remove excess logging from tests

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.14.0
    • Component/s: None
    • Labels:

      Description

      TestLocalExchange and TestLoad have this issue.

      See example

      Running org.apache.drill.exec.physical.impl.TestLocalExchange#testGroupByMultiFields
      Plan: {
        "head" : {
          "version" : 1,
          "generator" : {
            "type" : "ExplainHandler",
            "info" : ""
          },
          "type" : "APACHE_DRILL_PHYSICAL",
          "options" : [ {
            "kind" : "LONG",
            "accessibleScopes" : "ALL",
            "name" : "planner.width.max_per_node",
            "num_val" : 2,
            "scope" : "SESSION"
          }, {
            "kind" : "BOOLEAN",
            "accessibleScopes" : "ALL",
            "name" : "planner.enable_mux_exchange",
            "bool_val" : true,
            "scope" : "SESSION"
          }, {
            "kind" : "BOOLEAN",
            "accessibleScopes" : "ALL",
            "name" : "planner.enable_demux_exchange",
            "bool_val" : false,
            "scope" : "SESSION"
          }, {
            "kind" : "LONG",
            "accessibleScopes" : "ALL",
            "name" : "planner.slice_target",
            "num_val" : 1,
            "scope" : "SESSION"
          } ],
          "queue" : 0,
          "hasResourcePlan" : false,
          "resultMode" : "EXEC"
        },
        "graph" : [ {
          "pop" : "fs-scan",
          "@id" : 196611,
          "userName" : "travis",
          "files" : [ "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/6.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/9.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/3.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/1.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/2.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/7.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/0.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/5.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/4.json", "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable/8.json" ],
          "storage" : {
            "type" : "file",
            "enabled" : true,
            "connection" : "file:///",
            "config" : null,
            "workspaces" : {
              "root" : {
                "location" : "/home/travis/build/apache/drill/exec/java-exec/./target/org.apache.drill.exec.physical.impl.TestLocalExchange/root",
                "writable" : true,
                "defaultInputFormat" : null,
                "allowAccessOutsideWorkspace" : false
              },
              "tmp" : {
                "location" : "/home/travis/build/apache/drill/exec/java-exec/./target/org.apache.drill.exec.physical.impl.TestLocalExchange/dfsTestTmp/1527026062606-0",
                "writable" : true,
                "defaultInputFormat" : null,
                "allowAccessOutsideWorkspace" : false
              },
              "default" : {
                "location" : "/home/travis/build/apache/drill/exec/java-exec/./target/org.apache.drill.exec.physical.impl.TestLocalExchange/root",
                "writable" : true,
                "defaultInputFormat" : null,
                "allowAccessOutsideWorkspace" : false
              }
            },
            "formats" : {
              "psv" : {
                "type" : "text",
                "extensions" : [ "tbl" ],
                "delimiter" : "|"
              },
              "csv" : {
                "type" : "text",
                "extensions" : [ "csv" ],
                "delimiter" : ","
              },
              "tsv" : {
                "type" : "text",
                "extensions" : [ "tsv" ],
                "delimiter" : "\t"
              },
              "httpd" : {
                "type" : "httpd",
                "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\""
              },
              "parquet" : {
                "type" : "parquet"
              },
              "json" : {
                "type" : "json",
                "extensions" : [ "json" ]
              },
              "pcap" : {
                "type" : "pcap"
              },
              "avro" : {
                "type" : "avro"
              },
              "sequencefile" : {
                "type" : "sequencefile",
                "extensions" : [ "seq" ]
              },
              "csvh" : {
                "type" : "text",
                "extensions" : [ "csvh" ],
                "extractHeader" : true,
                "delimiter" : ","
              },
              "txt" : {
                "type" : "text",
                "extensions" : [ "txt" ],
                "delimiter" : "\u0000"
              },
              "ssv" : {
                "type" : "text",
                "extensions" : [ "ssv" ],
                "delimiter" : " "
              },
              "csvh-test" : {
                "type" : "text",
                "extensions" : [ "csvh-test" ],
                "skipFirstLine" : true,
                "extractHeader" : true,
                "delimiter" : ","
              }
            }
          },
          "format" : {
            "type" : "json",
            "extensions" : [ "json" ]
          },
          "columns" : [ "`dept_id`", "`mng_id`", "`some_id`" ],
          "selectionRoot" : "file:/home/travis/build/apache/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.TestLocalExchange/root/empTable",
          "cost" : 90.0
        }, {
          "pop" : "hash-aggregate",
          "@id" : 196610,
          "child" : 196611,
          "cardinality" : 1.0,
          "initialAllocation" : 1000000,
          "maxAllocation" : 10000000000,
          "aggPhase" : "PHASE_1of2",
          "groupByExprs" : [ {
            "ref" : "`dept_id`",
            "expr" : "`dept_id`"
          }, {
            "ref" : "`mng_id`",
            "expr" : "`mng_id`"
          }, {
            "ref" : "`some_id`",
            "expr" : "`some_id`"
          } ],
          "aggrExprs" : [ {
            "ref" : "`numEmployees`",
            "expr" : "count(1) "
      

      These excess logs pollute the logs of our build and make it harder to find issues.

        Attachments

          Activity

            People

            • Assignee:
              timothyfarkas Timothy Farkas
              Reporter:
              timothyfarkas Timothy Farkas
              Reviewer:
              Vova Vysotskyi

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment