Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-6347

Inconsistent method name "field".

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.14.0
    • None

    Description

      The following method is names as "field", but the method is mainly doing appending. So that, rename the method as "append" should be better.

       private void field(String label, String value) {
            indent();
            out.append(label)
               .append(" = ")
               .append(value)
               .append("\n");
          }
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            BruceKuiLIU KuiLIU
            BruceKuiLIU KuiLIU
            Vlad Rozov Vlad Rozov
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment