Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-6347

Inconsistent method name "field".

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.14.0
    • Component/s: None
    • Labels:

      Description

      The following method is names as "field", but the method is mainly doing appending. So that, rename the method as "append" should be better.

       private void field(String label, String value) {
            indent();
            out.append(label)
               .append(" = ")
               .append(value)
               .append("\n");
          }
      

        Attachments

          Activity

            People

            • Assignee:
              BruceKuiLIU KuiLIU
              Reporter:
              BruceKuiLIU KuiLIU
              Reviewer:
              Vlad Rozov

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment