[DRILL-5746] Pcap PR manually edited Protobuf files, values lost on next build

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.12.0
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 28/Aug/17 22:29
• Updated: 07/Nov/17 10:31
• Resolved: 07/Nov/17 10:31

Description

Drill recently accepted the pcap format plugin. As part of that work, the author added a new operator type, PCAP_SUB_SCAN_VALUE.

But, apparently this was done by editing the generated Protobuf files to add the values, rather than modifying the protobuf definitions and rebuilding the generated files. The result is, on the next build of the Protobuf sources, the following compile error appears:

[ERROR] /Users/paulrogers/git/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java:[80,41] error: cannot find symbol
[ERROR] symbol:   variable PCAP_SUB_SCAN_VALUE
[ERROR] location: class CoreOperatorType

The solution is to properly edit the Protobuf definitions with the required symbol.

Issue Links

• Is contained by: DRILL-5716 Queue-based memory assignment for buffering operators