[DRILL-5597] Incorrect "bits" vector allocation in nullable vectors allocateNew()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.12.0
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 20/Jun/17 02:09
• Updated: 17/Aug/17 03:36
• Resolved: 17/Aug/17 03:36

Description

Consider the following code in a generated nullable vector, such as NullableBigIntVector:

  public void allocateNew(int valueCount) {
    try {
      values.allocateNew(valueCount);
      bits.allocateNew(valueCount+1);

There are as may "bits" entries as data entries, no need to allocate an extra 1. When the valueCount is a power of two, the error will cause the allocation of twice as large a vector as necessary. (128K, say, instead of 64K, since 64K+1 power-of-two rounds to 128K.)

By contrast the +1 correction is needed for offset vectors, but the "bits" vector is not an offset vector.

By contrast, another variation of the same method is correct:

  public void allocateNew(int totalBytes, int valueCount) {
    try {
      values.allocateNew(totalBytes, valueCount);
      bits.allocateNew(valueCount);

Issue Links

• Is contained by: DRILL-5601 Rollup of External Sort memory management fixes