[DRILL-5547] Drill config options and session options do not work as intended

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.12.0
• Component/s: Server
• Labels: ready-to-commit
• Assignee: Venkata Jyothsna Donapati
• Reporter: Karthikeyan Manivannan
• Reviewer: Paul Rogers
• Created: 26/May/17 21:37
• Updated: 03/Sep/17 07:00
• Resolved: 03/Sep/17 07:00

Description

In Drill, session options should take precedence over config options. But several of these session options are assigned hard-coded default values when the option validators are initialized. Because of this config options will never be read and honored even if the user did not specify the session option.

ClassCompilerSelector.JAVA_COMPILER_VALIDATOR uses CompilerPolicy.DEFAULT as the default value. This default value gets into the session options map via the initialization of validators in SystemOptionManager.

Now any piece of code that tries to check if a session option is set will never see a null, so it will always use that value and never try to look into the config options. For example, in the following piece of code from ClassCompilerSelector (), the policy will never be read from the config file.

policy = CompilerPolicy.valueOf((value != null) ? value.string_val.toUpperCase() : config.getString(JAVA_COMPILER_CONFIG).toUpperCase());

Issue Links

• links to: GitHub Pull Request #868