Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-5405

Add missing operator types without dependency on protobuf enum

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.10.0
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Source - https://github.com/apache/drill/pull/214#discussion_r42687575

      When operators are not added into CoreOperatorType enum, they are displayed on Web UI as UNKNOWN_OPERATOR.
      Screenshots:
      now -> unknown_operator.JPG
      should be -> maprdb_sub_scan.JPG

      Though plugins work fine without this changes, it's still would be nice to display operator type on Web UI.
      But dependency on protobuf enum removes the ability for format plugins to truly be drop-in pluggable.
      In this case as option we may need to refactor this interface to just return a String and not use the protobuf enum, or have a separate "notes" field if we want to have a generic filescan operator ID in this enum with extra data to say what kind of scan we used.

        Attachments

        1. maprdb_sub_scan.JPG
          50 kB
          Arina Ielchiieva
        2. unknown_operator.JPG
          46 kB
          Arina Ielchiieva

          Issue Links

            Activity

              People

              • Assignee:
                arina Arina Ielchiieva
                Reporter:
                arina Arina Ielchiieva
                Reviewer:
                Karthikeyan Manivannan
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: