[DRILL-5316] C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.11.0
• Component/s: Client - C++
• Labels: ready-to-commit
• Assignee: Robert Hou
• Reporter: Rob Wu
• Reviewer: Robert Hou
• Created: 07/Mar/17 00:41
• Updated: 27/Jul/17 00:14
• Resolved: 20/Mar/17 19:55

Description

When connecting to drillbit with Zookeeper, occasionally the C++ client would crash without any reason.

A further look into the code revealed that during this call
rc=zoo_get_children(p_zh.get(), m_path.c_str(), 0, &drillbitsVector);

zoo_get_children returns ZOK (0) but drillbitsVector.count is 0.
This causes drillbits to stay empty and thus
causes err = zook.getEndPoint(drillbits[drillbits.size() -1], endpoint); to crash

Size check should be done to prevent this from happening

Issue Links

• links to: GitHub Pull Request #772