[DRILL-5311] C++ connector connect doesn't check handshake result for timeout

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.11.0
• Component/s: Client - C++
• Labels: ready-to-commit
• Assignee: Sudheesh Katkam
• Reporter: Laurent Goujon
• Created: 02/Mar/17 22:00
• Updated: 21/Mar/17 17:34
• Resolved: 20/Mar/17 19:56

Description

The C++ connector connect methods returns okay as soon as the tcp connection is succesfully established between client and server, and the handshake message is sent. However it doesn't wait for handshake to have completed.

The consequence is that if handshake failed, the error is deferred to the first query, which might be unexpected by the application.

I believe that validateHanshake method in drillClientImpl should wait for the handshake to complete, as it seems a bit more saner...

Issue Links

• links to: GitHub Pull Request #770