[DRILL-5252] A condition returns always true

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Labels: ready-to-commit
• Assignee: Unassigned
• Reporter: JC
• Reviewer: Paul Rogers
• Created: 10/Feb/17 20:45
• Updated: 30/Mar/17 22:57
• Resolved: 02/Mar/17 22:50

Description

I've found the following code smell in recent github snapshot.
Path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java

287 
288   @Override
289   public Boolean visitNullConstant(TypedNullConstant e, LogicalExpression value) throws RuntimeException {
290     if (!(value instanceof TypedNullConstant)) {
291       return false;
292     }
293     return e.getMajorType().equals(e.getMajorType());
294   }
295

Should it be like this?

292     }
293     return value.getMajorType().equals(e.getMajorType());
294   }

Issue Links

• links to: GitHub Pull Request #745