[DRILL-5112] Unit tests derived from PopUnitTestBase fail in IDE due to config errors

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.10.0
• Labels: ready-to-commit
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Reviewer: Chunhui Shi
• Created: 07/Dec/16 01:17
• Updated: 28/Mar/17 22:39
• Resolved: 13/Dec/16 00:45

Description

Drill provides a wide variety of unit tests. Many derive from PopUnitTestBase to test the Physical OPerators.

The tests use a default configuration:

protected static DrillConfig CONFIG;

  @BeforeClass
  public static void setup() {
    CONFIG = DrillConfig.create();
  }

The tests rely on config settings specified in the pom.xml file (see note below.) When run in Eclipse, no such config exists, so the tests use only the default config. The defaults allow a web server to be started.

Many tests start multiple Drillbits using the above config. When this occurs, each tries to start a web server. The second one fails because the HTTP port is already in use.

The solution is to initialize the config using the same settings as used in the BaseTestQuery test case: the unit tests then work fine in Eclipse.

As an aside, having multiple ways to set up the Drill config (and other items) leads to much wasted time as each engineer must learn the quirks of each test hierarchy.

Issue Links

• links to: GitHub Pull Request #681