Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-5108

Reduce output from Maven git-commit-id-plugin

Details

    Description

      The git-commit-id-plugin grabs information from Git to display during a build. It prints many e-mail addresses and other generic project information. As part of the effort to trim down unit test output, we propose to turn off the verbose output from this plugin.

      Specific change:

            <plugin>
              <groupId>pl.project13.maven</groupId>
              <artifactId>git-commit-id-plugin</artifactId>
              ...
              <configuration>
               <verbose>false</verbose>
      

      That is, change the verbose setting from true to false.

      In the unlikely event that some build process depends on the verbose output, we can make the setting a configurable parameter, defaulting to false.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user paul-rogers opened a pull request:

            https://github.com/apache/drill/pull/680

            DRILL-5108: Reduce output from Maven git-commit-id-plugin

            The git-commit-id-plugin grabs information from Git to display during a
            build. It prints many e-mail addresses and other generic project
            information. As part of the effort to trim down unit test output, we
            propose to turn off the verbose output from this plugin by default.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/paul-rogers/drill DRILL-5108

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/drill/pull/680.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #680


            commit f2c7d155f018fec597c6be797a31eb77a03c62ce
            Author: Paul Rogers <progers@maprtech.com>
            Date: 2016-12-07T03:38:38Z

            DRILL-5108: Reduce output from Maven git-commit-id-plugin

            The git-commit-id-plugin grabs information from Git to display during a
            build. It prints many e-mail addresses and other generic project
            information. As part of the effort to trim down unit test output, we
            propose to turn off the verbose output from this plugin by default.


            githubbot ASF GitHub Bot added a comment - GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/680 DRILL-5108 : Reduce output from Maven git-commit-id-plugin The git-commit-id-plugin grabs information from Git to display during a build. It prints many e-mail addresses and other generic project information. As part of the effort to trim down unit test output, we propose to turn off the verbose output from this plugin by default. You can merge this pull request into a Git repository by running: $ git pull https://github.com/paul-rogers/drill DRILL-5108 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/680.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #680 commit f2c7d155f018fec597c6be797a31eb77a03c62ce Author: Paul Rogers <progers@maprtech.com> Date: 2016-12-07T03:38:38Z DRILL-5108 : Reduce output from Maven git-commit-id-plugin The git-commit-id-plugin grabs information from Git to display during a build. It prints many e-mail addresses and other generic project information. As part of the effort to trim down unit test output, we propose to turn off the verbose output from this plugin by default.
            zfong Zelaine Fong added a comment -

            Assigned Reviewer to shamirwasia

            zfong Zelaine Fong added a comment - Assigned Reviewer to shamirwasia
            githubbot ASF GitHub Bot added a comment -

            Github user Ben-Zvi commented on a diff in the pull request:

            https://github.com/apache/drill/pull/680#discussion_r91358221

            — Diff: pom.xml —
            @@ -383,7 +383,7 @@

            <configuration>
            <dateFormat>dd.MM.yyyy '@' HH:mm:ss z</dateFormat>

            • <verbose>true</verbose>
              + <verbose>false</verbose>
                • End diff –

            Can this be undone by giving the mvn command line option -Dverbose ?

            githubbot ASF GitHub Bot added a comment - Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/680#discussion_r91358221 — Diff: pom.xml — @@ -383,7 +383,7 @@ <configuration> <dateFormat>dd.MM.yyyy '@' HH:mm:ss z</dateFormat> <verbose>true</verbose> + <verbose>false</verbose> End diff – Can this be undone by giving the mvn command line option -Dverbose ?
            githubbot ASF GitHub Bot added a comment -

            Github user sudheeshkatkam commented on the issue:

            https://github.com/apache/drill/pull/680

            What does the non verbose message look like?

            githubbot ASF GitHub Bot added a comment - Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/680 What does the non verbose message look like?
            githubbot ASF GitHub Bot added a comment -

            Github user paul-rogers commented on the issue:

            https://github.com/apache/drill/pull/680

            The non-verbose output is, indeed, blank. The value of the plugin seems to be that it creates Maven variables that can be used elsewhere in the POM for various purposes. Dumping to console is an "extra."

            githubbot ASF GitHub Bot added a comment - Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/680 The non-verbose output is, indeed, blank. The value of the plugin seems to be that it creates Maven variables that can be used elsewhere in the POM for various purposes. Dumping to console is an "extra."
            githubbot ASF GitHub Bot added a comment -

            Github user sudheeshkatkam commented on the issue:

            https://github.com/apache/drill/pull/680

            +1

            githubbot ASF GitHub Bot added a comment - Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/680 +1
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/drill/pull/680

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/680

            Fixed in 11645dc

            sudheeshkatkam Sudheesh Katkam added a comment - Fixed in 11645dc
            paul-rogers Paul Rogers added a comment -

            This is a development issue, no QA verification needed.

            paul-rogers Paul Rogers added a comment - This is a development issue, no QA verification needed.
            kkhatua Kunal Khatua added a comment -

            Closing as no QA verification is required

            kkhatua Kunal Khatua added a comment - Closing as no QA verification is required

            People

              paul-rogers Paul Rogers
              paul-rogers Paul Rogers
              Sorabh Hamirwasia Sorabh Hamirwasia
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: